Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update esti to use LAKEFSACTION prefix for env #7105

Merged
merged 1 commit into from
Dec 4, 2023
Merged

test: update esti to use LAKEFSACTION prefix for env #7105

merged 1 commit into from
Dec 4, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 3, 2023

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@nopcoder nopcoder self-assigned this Dec 3, 2023
@nopcoder nopcoder added area/testing Improvements or additions to tests exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Dec 3, 2023
N-o-Z
N-o-Z approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

esti/action_files/action_pre_commit.yaml
check_env_vars: "{{"{{ ENV.LAKEFSACTION_VAR }}"}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@nopcoder nopcoder merged commit f1d923a into master Dec 4, 2023
38 of 40 checks passed
@nopcoder nopcoder deleted the fix/esti-hook branch December 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@itaiad200 itaiad200 Awaiting requested review from itaiad200

@arielshaqed arielshaqed Awaiting requested review from arielshaqed

Assignees

@nopcoder nopcoder

Labels
area/testing Improvements or additions to tests exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopcoder @N-o-Z